Fixtures: Add aiida_computer_localhost and aiida_computer_ssh
#5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
changed the title
aiida_computer_localhost and aiida_computer_ssh
|
These fixtures are required for #5787 . Once this is approved and merged, I will go through the unit tests and clean them up, using the fixtures instead of test manually constructing computers. |
sphuber
force-pushed
the
feature/fixture-aiida-computer
branch
from
66fb394
to
286804a
Compare
This is a convenience property that calls `is_user_configured` but automatically passed the current default user.
These fixtures return an instance of `Computer` that represents the localhost computer with `core.local` and `core.ssh` as the transport type, respectively. By default, the computers are also configured. The `aiida_computer_ssh` will even create an SSH key pair automatically for the session such that the SSH transport can actually be opened. The fixtures both call the more generic `aiida_computer` which returns a factory that gives greater control on how the computer is created and configured. Usuallly the two wrappers are all that is needed for the majority of tests. The fixtures are placed in `pytest_fixtures` instead of the `conftest.py` of `aiida-core`, because `aiida_computer` and `aiida_computer_local` should be available to plugins. The `aiida_computer_ssh` is probably mostly useful for tests in `aiida-core`, but for clarity it is kept together with `aiida_computer_local`. The existing fixture `aiida_localhost` now simply uses the `aiida_computer_local` fixture as the implementation.
sphuber
force-pushed
the
feature/fixture-aiida-computer
branch
from
286804a
to
5d3c55a
Compare
|
Cheers @ltalirz 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixtures return an instance of
Computerthat represents thelocalhost computer with
core.localandcore.sshas the transporttype, respectively. By default, the computers are also configured. The
aiida_computer_sshwill even create an SSH key pair automatically forthe session such that the SSH transport can actually be opened.
The fixtures both call the more generic
aiida_computerwhich returns afactory that gives greater control on how the computer is created and
configured. Usuallly the two wrappers are all that is needed for the
majority of tests.
The fixtures are placed in
pytest_fixturesinstead of theconftest.pyof
aiida-core, becauseaiida_computerandaiida_computer_localhostshould be available to plugins. The
aiida_computer_sshis probablymostly useful for tests in
aiida-core, but for clarity it is kepttogether with
aiida_computer_localhost.These new fixtures provide the same functionality as
aiida_localhostbut are more flexible. The
aiida_localhostfixture is thereforedeprecated.