🔧 Type annotate aiida/orm/utils/serialize.py
#5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
changed the title
aiida/orm/utils/serialize.py
sphuber
reviewed
Dec 13, 2022
aiida/orm/utils/serialize.py
Outdated
| deserialized = loader.construct_scalar(serialized) | ||
| def enum_constructor(loader: yaml.Loader, serialized: yaml.Node) -> Enum: | ||
| """Construct an enum from the serialized representation.""" | ||
| deserialized: str = loader.construct_scalar(serialized) # type: ignore |
There was a problem hiding this comment.
What are the warnings here for the loader.construct_scalar? If they cannot be fixed, should we at least maybe add the more specific error code to ignore instead of a blanket ignore?
There was a problem hiding this comment.
I've added ignore if specific errors.
They are needed to because, essentially, the constructors have been written assuming that the objects have been serialized using the complimentary represent_ functions in this module.
To remove them, you would need to start adding in assert isinstance checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.