Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add --without-daemon flag to benchmark script #5839

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Dec 15, 2022

The benchmark script sends a number of ArithmeticAddCalculations to the daemon and reports the time taken per process at the end. This is intended for users to run to get an idea of the performance of their setup. However, running over the daemon is not necessary the most straightforward when it comes to analysing the results and the timings can differ quite a bit. It makes more sense to simply run the N jobs serially, which should give a better more consistent picture of the average overhead per process.

@sphuber sphuber requested a review from ltalirz December 15, 2022 12:53
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Feel free to merge as-is;

it might also make sense to change the default behavior and update the docs - probably testing without daemon is more meaningful for most users as you mention.

The benchmark script sends a number of `ArithmeticAddCalculation`s to
the daemon and reports the time taken per process at the end. This is
intended for users to run to get an idea of the performance of their
setup. However, running over the daemon is not necessary the most
straightforward when it comes to analysing the results and the timings
can differ quite a bit. It makes more sense to simply run the N jobs
serially, which should give a better more consistent picture of the
average overhead per process.
@sphuber sphuber force-pushed the feature/benchmark-script-without-daemon branch from b8ec5e8 to 788cd24 Compare December 19, 2022 09:59
@sphuber sphuber merged commit f2c0f2c into aiidateam:main Dec 19, 2022
@sphuber sphuber deleted the feature/benchmark-script-without-daemon branch December 19, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants