reduce to 10 iterations in performance benchmark #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "slow" setups, the overhead per process can be of the order of 2s. No need to make the user wait 3 minutes. Even for the fastest machines with ~0.2s per process, 10 iterations are plenty.
Useful when testing different configurations in different profiles.
sphuber
requested changes
Dec 23, 2022
docs/source/howto/include/scripts/performance_benchmark_base.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
ltalirz
force-pushed
the
update-perf-script
branch
from
26398d8
to
a011c88
Compare
sphuber
reviewed
Dec 23, 2022
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
|
Thanks for the review! |
sphuber
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "slow" setups, the overhead per process can be of the order of 2s. No need to make the user wait 3 minutes.
Even for the fastest machines with ~0.2s per process, 10 iterations are plenty.