icsd plugin: determine is_theoretical #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @eimrek . The changes now look good to me. The only thing really missing is some kind of test, but I realise this is tricky for this case. Could you at least confirm to me that you have tried this version of the code with an actual ICSD server? If so I think we can merge it. |
|
thanks @sphuber for the check. Yes, everything seemed to work correctly after some light testing with an ICSD mysql server. |
sphuber
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra
{"is_theoretical": True/False}for ICSD entries queried from the MySQL database.Couple of notes:
is_theoreticalextra to the MySQL query, not a query done through the web interface.