verdi code create: Do not prompt for --with-mpi
#5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2023 16:30
This option prevents linebreaks after keys in dictionaries if the values exceed the maximum column width. This happens for example in dictionaries where values are long multiline strings. If the string exceeds the max length, it is put on the next line, which is not too bad, but so are all other values in the dictionary, even those that are not too long. This leads to difficult to read formatting.
The `--with-mpi/--no-with-mpi` flag allows to set the `with_mpi` attribute on the code. This attribute is optional and allows `None` as a default but since the option is a boolean flag, in interactive mode, it prompts and forces the user to choose `True` or `False` and it is not possible to leave it unset, which should be the default behavior. To solve this, `DynamicEntryPointCommandGroup.create_option` method, which is used to dynamically generate the CLI options for the various code subclasses, is updated to remove the prompt for flag options if the default is `None`. Now, the option will no longer prompt in interactive mode (and set `None` as the default), but the flag can still be used in non-interactive mode.
|
Yes, I checked it manually: (aiida_dev) sph@invader:~/code/aiida/env/dev/aiida-core$ verdi code create core.code.installed
Report: enter ? for help.
Report: enter ! to ignore the default and set no value.
Computer: localhost
Absolute filepath executable: bash
Label: testing
Description:
Description: !@
Default `CalcJob` plugin: core.arithmetic.add
Escape using double quotes [y/N]:
Success: Created InstalledCode<29212>But indeed there are test for interactive mode, and the fact that I didn't have to add a line in the user input for that test, testifies that the new option is not prompted for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5930
The
--with-mpi/--no-with-mpiflag allows to set thewith_mpiattribute on the code. This attribute is optional and allows
Noneasa default but since the option is a boolean flag, in interactive mode,
it prompts and forces the user to choose
TrueorFalseand it is notpossible to leave it unset, which should be the default behavior.
To solve this,
DynamicEntryPointCommandGroup.create_optionmethod,which is used to dynamically generate the CLI options for the various
code subclasses, is updated to remove the prompt for flag options if the
default is
None. Now, the option will no longer prompt in interactivemode (and set
Noneas the default), but the flag can still be used innon-interactive mode.