Fix incorrect import of exception from kiwipy.communications
#5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aiida.engine.processes.control._resolve_futures` method was importing the `CommunicationTimeout` from `kiwipy.communications` however this class does not exist. Probably the `TimeoutError` was meant, which is simply an alias of `concurrent.futures.TimeoutError`.
unkcpz
reviewed
Mar 31, 2023
| @@ -262,7 +262,7 @@ def handle_result(result): | |||
| # unwrap is need here since LoopCommunicator will also wrap a future | |||
| future = unwrap_kiwi_future(future) | |||
| result = future.result() | |||
| except communications.CommunicationTimeout: | |||
| except communications.TimeoutError: | |||
There was a problem hiding this comment.
Just check the history, it used to be from aiida.manage.external.rmq import CommunicationTimeout.
There was a problem hiding this comment.
And there it used to be defined as CommunicationTimeout = kiwipy.communications.TimeoutError # pylint: disable=invalid-name So this PR is restoring that behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aiida.engine.processes.control._resolve_futuresmethod was importing theCommunicationTimeoutfromkiwipy.communicationshowever this class does not exist. Probably theTimeoutErrorwas meant, which is simply an alias ofconcurrent.futures.TimeoutError.