QueryBuilder: Deprecate debug argument and use logger
#6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/querybuilder-log-level
branch
2 times, most recently
from
8d58bc2
to
9734a19
Compare
The `QueryBuilder` defined the `debug` flag, which when set to `True` would cause certain methods to print additional debug information. This should go through the logging functionality, however, so the print statements are replaced by a `logger.debug` call. Since the debug messages can now be activated by configuring the logger log level, the `debug` argument is no longer needed and is deprecated.
sphuber
force-pushed
the
fix/querybuilder-log-level
branch
2 times, most recently
from
8188915
to
86bddc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QueryBuilderdefined thedebugflag, which when set toTruewould cause certain methods to print additional debug information. This should go through the logging functionality, however, so the print statements are replaced by alogger.debugcall.Since the debug messages can now be activated by configuring the logger log level, the
debugargument is no longer needed and is deprecated.