Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Transport to use pydantic for configuration #6198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 30, 2023

No description provided.

@sphuber sphuber force-pushed the fix/transport-model-pydantic branch 2 times, most recently from 6f4e549 to 0909304 Compare January 11, 2024 09:51
@sphuber sphuber force-pushed the fix/transport-model-pydantic branch 3 times, most recently from c30af1f to d606a83 Compare March 13, 2024 09:40
@agoscinski
Copy link
Contributor

Is it worth to tag this with a v3.0.0 milestone where we could introduce such breaking changes?

@sphuber
Copy link
Contributor Author

sphuber commented May 29, 2024

Is it worth to tag this with a v3.0.0 milestone where we could introduce such breaking changes?

The breaking changes are actually quite minimal. I don't remember by heart, but it may be just the order in which options are prompted for and some other minimal things. Mostly the changes are just in implementation.

And I am not sure if there actually ever will be a v3 😅 There are no concrete plans for now in any case. But definitely worth a discussion at some point perhaps.

@sphuber sphuber force-pushed the fix/transport-model-pydantic branch from d606a83 to aa42fd7 Compare May 30, 2024 09:35
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.51%. Comparing base (ef60b66) to head (0c5f715).
Report is 15 commits behind head on main.

Files Patch % Lines
src/aiida/cmdline/commands/cmd_computer.py 97.15% 1 Missing ⚠️
src/aiida/transports/plugins/ssh.py 96.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6198      +/-   ##
==========================================
+ Coverage   77.51%   77.51%   +0.01%     
==========================================
  Files         560      562       +2     
  Lines       41444    41715     +271     
==========================================
+ Hits        32120    32333     +213     
- Misses       9324     9382      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants