Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump artifact action to v4 #6228

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Bump artifact action to v4 #6228

merged 1 commit into from
Dec 19, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 18, 2023

The changes should significantly speed up artifact upload, see https://github.com/actions/upload-artifact#v4---whats-new

@unkcpz unkcpz force-pushed the bump-artifact-upload-action-v4 branch from 33839d7 to dcac853 Compare December 18, 2023 13:43
@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

It is a new version of upload-artifact action which brings the benefits, but @danielhollas and I encounter some issue in aiidalab-docker-stack, so I'll keep this PR as draft until we are clear on what caused the problem and how to precede.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5015f5f) 80.74% compared to head (dcac853) 80.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6228   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files         548      548           
  Lines       40221    40221           
=======================================
  Hits        32471    32471           
  Misses       7750     7750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 19, 2023

Share some gifs from the just closed issue in upload-artifact

Before:

image

After, no more excuses for the slack on the desk.

image

@unkcpz unkcpz marked this pull request as ready for review December 19, 2023 15:49
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz

@sphuber sphuber merged commit bfdb282 into main Dec 19, 2023
34 checks passed
@sphuber sphuber deleted the bump-artifact-upload-action-v4 branch December 19, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants