node graph generate accepts multiple ROOT_NODES
#6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a known problem of command line interfaces that have an option that accepts multiple values. The parser will be greedy and treats other (optional) positional arguments as a value for the option. The distinction has to be made explicitly by the caller. You can insert the |
bilke
force-pushed
the
graph-multiple-root
branch
from
ce1979a
to
64e713e
Compare
TODO: output path must explicitly stated.
root nodes. As suggested by @sphuber.
This is necessary because otherwise if a user wants to specify the
output file when using multiple root nodes, they would have to specify a
single root node again or the output file would be mistaked for the
deprecated root node argument:
verdi node graph generate -N 1 2 -- 1 output.pdf
sphuber
force-pushed
the
graph-multiple-root
branch
from
64e713e
to
0fb1ff9
Compare
sphuber
approved these changes
Apr 4, 2024
|
Thanks a lot for the contribution @bilke |
GeigerJ2
pushed a commit
to qiaojunfeng/aiida-core
that referenced
this pull request
Apr 10, 2024
…eam#6338) So far, the command only allowed to specify a single root node through a positional argument. However, in some cases having multiple root nodes are perfectly sensible. Unfortunately, simply changing the positional argument to accept multiple nodes won't work because the command also accepts a second optional positional argument to specify the output filename. Making the root node accept multiple values will make it greedy and it will always mistake the output filename as another root node specifier. As an alternative solution the `-N/--nodes` and `-O/--output-file` options are added that replace the positional arguments that are now deprecated. Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
GeigerJ2
pushed a commit
to GeigerJ2/aiida-core
that referenced
this pull request
Apr 16, 2024
…eam#6338) So far, the command only allowed to specify a single root node through a positional argument. However, in some cases having multiple root nodes are perfectly sensible. Unfortunately, simply changing the positional argument to accept multiple nodes won't work because the command also accepts a second optional positional argument to specify the output filename. Making the root node accept multiple values will make it greedy and it will always mistake the output filename as another root node specifier. As an alternative solution the `-N/--nodes` and `-O/--output-file` options are added that replace the positional arguments that are now deprecated. Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #6335.
Related to https://aiida.discourse.group/t/node-graph-generate-with-multiple-root-nodes/353.
TODO
Current usage is
if the output is left out then the last root node name would be used as the output file name.
@sphuber Do you have an idea / opinion how the cli interface should handle that?