Fixes #722 issue affecting failed workflows #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We overwrote the constructor for Persistence but did not call the super class. This was a problem because the super constructor was actually adding the class as a listener of the MONITOR. It is the MONITOR that would tell the persistence when a process had crashed (because of exception). This means that the pickle was not being moved to failed and therefore the workflow would be re-ran.
|
Martin! Good to hear from you mate. I am curious though, why did this not happen when I just ran the daemon as opposed to manually calling |
|
@sphuber I asked myself the same thing. Turns out the bug was sorta there with the daemon as well. What would happen is that the |
sphuber
approved these changes
Sep 27, 2017
|
Pulled the changes locally and the zombie test now runs as expected. |
|
Thanks guys, it also works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We overwrote the constructor for Persistence but did not call the super
class. This was a problem because the super constructor was actually
adding the class as a listener of the MONITOR. It is the MONITOR that
would tell the persistence when a process had crashed (because of
exception). This means that the pickle was not being moved to failed
and therefore the workflow would be re-ran.