Improved error import exception tests #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror When attempting to load db tests through the loadTestsFromName of the test loader that contained import errors, an AttributeError would be thrown with the cryptic message AttributeError: 'module' object has no attribute 'process' To provide a more clear description of the problem we put the call to load the tests in a try except block and catch the AttributeError. If it is caught we attempt to import it, which should then trigger the actual import error, which we then print to screen and exit
DropD
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #953
When attempting to load db tests through the
loadTestsFromNameof thetest loader that contained import errors, an
AttributeErrorwould bethrown with the cryptic message
To provide a more clear description of the problem we put the call to
load the tests in a try except block and catch the
AttributeError.If it is caught we attempt to import it, which should then trigger the
actual import error, which we then print to screen and exit