Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code formatting #161

Merged
merged 19 commits into from Jun 23, 2022
Merged

Update code formatting #161

merged 19 commits into from Jun 23, 2022

Conversation

yakutovicha
Copy link
Contributor

@yakutovicha yakutovicha commented Jun 13, 2022

fixes #35

In this PR I would like to gradually update the formatting of the package by trying different tools available out there. The commits in this PR will be: "Enable tool", and "Apply tool".

This would help us understand what change a specific tool does to the package.

@yakutovicha yakutovicha marked this pull request as draft June 13, 2022 13:27
@yakutovicha
Copy link
Contributor Author

I looked around to see what formatting tools people use, and this is what I came up with. Happy consider other suggestions.

@yakutovicha
Copy link
Contributor Author

Also mentioning @mkrack as the need for such an update came up during the review of #159

- Remove yapf and pylint from 'pre-commit' extras
- Upgrade pre-commit dependency
@yakutovicha yakutovicha marked this pull request as ready for review June 20, 2022 09:45
@yakutovicha
Copy link
Contributor Author

Since I haven't got any suggestions, I will go ahead with merging this PR.

@yakutovicha yakutovicha merged commit 7cf6d76 into develop Jun 23, 2022
@yakutovicha yakutovicha deleted the maintain/update-pre-commit branch June 23, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible formatter changes
1 participant