-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, bug fixes and adding tests #18
Draft
unkcpz
wants to merge
14
commits into
aiidateam:main
Choose a base branch
from
unkcpz:fea/mem-allocation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource can be set with #HQ or through CLI, but not both. The CLI options are removed from submit command.
5b56629
to
56f8345
Compare
- Change command to aiida-hq - add aiida-hq install <computer> - fix start server timeout problem - pre-commit lint
58e77e3
to
d525ff1
Compare
fef7c55
to
8bffb31
Compare
8db9734
to
181a29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is open since I use the branch to test the demo server lightweight scheduler integration. The PR bundles bunch of things include:
hq
using the fixture from hyperqueue repo.The major change I made in terms of resource setting is I didn't use
num_mpiprocs
and renamenum_cores
->num_cpus
, renamememory_Mb
->memory_mb
.The reason is that I think this kind of "meta-scheduler" for task farming is not inherit from either
ParEnvJobResource
as SGE type scheduler norNodeNumberJobResource
. When we use hyperqueue for task farming or for local machine as light-weight scheduler we only set number of cpus and size of memory to allocate for each job. The multi-node support of hyperqueue is under experiments and will not cover our use case from what I can expect. But this is the point worth to discuss, looking forward to see your opinions @giovannipizzi @mbercxIssues:
OSError: Failure
)HQ_SERVER_DIR
explicitly, to distinguish multiple server (see Distinguish hq-server folder to have multiple server for different machines share the same home It4innovations/hyperqueue#719)Must have features:
NodeNumberJobResource
as parent and provide option for use case on LUMI that will require multinode functionality of HQ.-N
is passed to alloc, the group name should be always exclusive. We don't want HQ to mess around to have many unbalanced jobs in different compute nodes.