Remove the _error_handlers list attribute from BaseRestartWorkChain
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
previously approved these changes
May 7, 2018
Because it was defined as a class attribute for the BaseRestartWorkChain each time the register_error_handler decorator was used, the method was appended to the exact same list, regardless of the workchain class to which it was supposed to be applied.
sphuber
force-pushed
the
fix_126_error_handlers_base_restart_workchain
branch
from
5ffee13
to
aed76a3
Compare
giovannipizzi
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Because it was defined as a class attribute for the BaseRestartWorkChain
each time the register_error_handler decorator was used, the method was
appended to the exact same list, regardless of the workchain class to
which it was supposed to be applied.