Fix import or URLError which has been removed in xmlschema
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of `xmlschema==1.2.0` the `xmlschema.exceptions.URLError` exception has been removed. This was just an alias for Python 2 and 3 compatibility reasons, which now that Python 2 support is dropped can be removed. Simply using `from urllib.error import URLError` addressed the problem.
greschd
approved these changes
Jun 4, 2020
|
I had already started this but then realized that |
|
Ah, perfect 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
As of
xmlschema==1.2.0thexmlschema.exceptions.URLErrorexceptionhas been removed. This was just an alias for Python 2 and 3 compatibility
reasons, which now that Python 2 support is dropped can be removed.
Simply using
from urllib.error import URLErroraddressed the problem.