ForceConstantsData: add filename and **kwargs to constructor
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor signature of the `SinglefileData` class, which is the base class of the `ForceConstantsData`, was updated sometime ago in `aiida-core` to include the `filename` and `**kwargs` arguments. These are now added, because in `aiida-core==2.0.0` having a different constructor will start to raise.
mbercx
approved these changes
Oct 26, 2020
sphuber
added a commit
that referenced
this pull request
Nov 17, 2020
) The constructor signature of the `SinglefileData` class, which is the base class of the `ForceConstantsData`, was updated sometime ago in `aiida-core` to include the `filename` and `**kwargs` arguments. These are now added, because in `aiida-core==2.0.0` having a different constructor will start to raise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598
The constructor signature of the
SinglefileDataclass, which is thebase class of the
ForceConstantsData, was updated sometime ago inaiida-coreto include thefilenameand**kwargsarguments. Theseare now added, because in
aiida-core==2.0.0having a differentconstructor will start to raise.