Re-enable formatting after define methods
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
added
the
pr/blocked
greschd
force-pushed
the
fix/formatting
branch
from
475406b
to
5211cea
Compare
greschd
changed the title
define methods
greschd
removed
the
pr/blocked
The `define` methods typically contained a `# yapf: disable` statement, but no matching `# yapf: enable`. As a result, formatting was disabled for the remainder of the files. This commit adds matching `enable` statements, and contains the resulting formatting changes.
greschd
force-pushed
the
fix/formatting
branch
from
5211cea
to
5c122d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calculations/__init__.pycontained a# yapf: disablestatement, but no# yapf: enable. My understanding is that single# yapf: disableare "allowed" only at the end of a specific line that shouldn't be formatted, otherwise it will apply for the entire rest of the file (see the examples in their README).Here we add a
# yapf: enablestatement after the things that shouldn't be formatted, and apply the resulting formatting changes.EDIT: Turns out
calculations/__init__.pyisn't the only affected file, updated the PR to add matching# yapf: enableeverywhere.