Protocols: Add usage of metadata/paral. overrides #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
force-pushed
the
fix/651/metadata-parallel-override
branch
from
fb0cbc0
to
002da7a
Compare
sphuber
reviewed
Feb 18, 2021
mbercx
force-pushed
the
fix/651/metadata-parallel-override
branch
from
002da7a
to
ffc373f
Compare
mbercx
force-pushed
the
fix/651/metadata-parallel-override
branch
from
ffc373f
to
1a6278a
Compare
|
@sphuber although I think the comment in your review is valid, I will open a separate PR to deal with the possibility of |
The `metadata` and `parallelization` inputs of the `PwCalculation`, stored in the `pw` namespace of the `PwBaseWorkChain`, are not (properly) used in the `get_builder_from_protocol()` method. Here we make the following changes to correct this issue: * Move the `metadata` inputs under `pw` in the base.yaml file. * Correctly obtain the `metadata` from the inputs in the `get_builder_from_protocol()` method of the `PwBaseWorkChain`. * Check if there is `parallelization` input in the `pw` namespace of the inputs, and if so add it to the builder in the `get_builder_from_protocol()` method of the `PwBaseWorkChain`.
mbercx
force-pushed
the
fix/651/metadata-parallel-override
branch
from
1a6278a
to
1bd67b4
Compare
|
2 addition tests, coming right up! |
sphuber
reviewed
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651
The
metadataandparallelizationinputs of thePwCalculation,stored in the
pwnamespace of thePwBaseWorkChain, are not(properly) used in the
get_builder_from_protocol()method. Here wemake the following changes to correct this issue:
metadatainputs underpwin the base.yaml file.metadatafrom the inputs in theget_builder_from_protocol()method of thePwBaseWorkChain.parallelizationinput in thepwnamespace of theinputs, and if so add it to the builder in the
get_builder_from_protocol()method of thePwBaseWorkChain.