New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devops: add GitHub Actions workflow for continuous deployment #776
Conversation
e7edf07
to
6972040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @sphuber! Had to read up a bit on GitHub actions to do a proper review. Still left some small questions and comments.
6972040
to
ef92b8f
Compare
This workflow will be triggered when a new tag is pushed that matches a semantic versioning pattern. If it is pushed to the main repository of the `aiidateam` account, a Python script `validate_release_tag.py` is run that will parse the `__version__` attribute of the package and compare it to the version of the tag. If they don't match, the workflow is aborted. Otherwise, the pre-commit and the unit test suite is ran, and when successfull, `flit` is used to build and publish the package to PyPI.
ef92b8f
to
27a5174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @sphuber! Looks good to me, let's see what happens if we add a new release tag. :)
This workflow will be triggered when a new tag is pushed that matches a semantic versioning pattern. If it is pushed to the main repository of the `aiidateam` account, a Python script `validate_release_tag.py` is run that will parse the `__version__` attribute of the package and compare it to the version of the tag. If they don't match, the workflow is aborted. Otherwise, the pre-commit and the unit test suite is ran, and when successfull, `flit` is used to build and publish the package to PyPI.
This workflow will be triggered when a new tag is pushed that matches a semantic versioning pattern. If it is pushed to the main repository of the `aiidateam` account, a Python script `validate_release_tag.py` is run that will parse the `__version__` attribute of the package and compare it to the version of the tag. If they don't match, the workflow is aborted. Otherwise, the pre-commit and the unit test suite is ran, and when successfull, `flit` is used to build and publish the package to PyPI.
Fixes #777
This workflow will be triggered when a new tag is pushed that matches a
semantic versioning pattern. If it is pushed to the main repository of
the
aiidateam
account, a Python scriptvalidate_release_tag.py
isrun that will parse the
__version__
attribute of the package andcompare it to the version of the tag. If they don't match, the workflow
is aborted.
Otherwise, the pre-commit and the unit test suite is ran, and when
successfull,
flit
is used to build and publish the package to PyPI.