Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubbard: add useful utility functions #996

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Nov 23, 2023

  1. HubbardUtils: nearest neighbour radius finder

    Add the possibility of finding a shell radius defining a sphere
    which contains the first (intersites) neighbours. This is helpful
    when using the `hp.x` code and having a structure containing
    onsite Hubbard atoms with different number of neighbours.
    bastonero committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b0883d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Add Hubbard initialization parameters

    The Hubbard parameters can now be initialized simply
    by perfoming a nearest neighbour analysis (pymatgen).
    Standardization of the lattice and the atomic positions
    can also be performed to have all the atoms within the
    unit cell (needed for the `pw.x` routine).
    bastonero committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e565295 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Fix logic and atomic ordering

    Pymatgen does not order the atoms by distance.
    There is not apparently any such option in the API.
    Folding is then now sepatated from standardization
    (the latter could produce larger structures).
    bastonero committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    dd2c788 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Improve inputs and refold with thr

    The refolding wasn't folding numbers
    close numerically to 1, e.g. 0.99999999.
    To circumvent the issue, a threshold is set,
    and it is possible to control it via input.
    Also, now the inputs for nearest neighbours
    are not passed via kwargs, but via an explicit
    dictionary input, which is then given via kwargs
    to the NN class.
    bastonero committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    badd882 View commit details
    Browse the repository at this point in the history
  2. Small adjustments

    bastonero committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    dcdb00a View commit details
    Browse the repository at this point in the history
  3. Fix pymatgen reference target for docs

    The url for pymatgen to generate interlinks
    across API packages is added.
    bastonero committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c8e04eb View commit details
    Browse the repository at this point in the history