Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.5? #2

Closed
ltalirz opened this issue Mar 18, 2020 · 5 comments
Closed

support python 3.5? #2

ltalirz opened this issue Mar 18, 2020 · 5 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Mar 18, 2020

I notice that this is currently the only plugin in the Quantum Mobile that requires python >= 3.6 [1] and therefore fails to install on ubuntu 16.04.

Is this necessary?

[1] Note: While the setup.json of aiida-wannier90 might look similar, somehow the requirement ending up on pypi is different:

aiida-wannier90: Requires: Python >=2.7, !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*
aiida-wannier90-workflows: Requires: Python >=3.6

@giovannipizzi
Copy link
Member

I think it's ok and we can do this now (maybe you are looking at the develop branch of aiida-wannier90, where we dropped py2, that's why they look similar now).

However note that in aiida-wannier90 we dropped py2 and are supporting only py >=3.6, so this problem will be there soon anyway. How much is this a problem?

@ltalirz
Copy link
Member Author

ltalirz commented Mar 18, 2020

Not a major problem - I can drop support for ubuntu 16.04.

Would just not have liked to do this without reason.

@qiaojunfeng
Copy link
Collaborator

Thanks! Now I keep the python_requires same as aiida-wannier90 v2.0.1: >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.* 0e3a4e9

@sphuber
Copy link

sphuber commented Mar 19, 2020

Just for reference, python 3.5 will be EOL on September 13 2020 anyway, so pretty soon aiida-core will also be dropping support for it.

@giovannipizzi
Copy link
Member

Fixed in v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants