Catch TimeoutError of add_rpc_subscriber in Process.init
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `add_rpc_subscriber` call on the communicator in the `init` call of a `Process` can timeout with a `TimeoutError`, but this should not topple the process itself. Instead, it should log the error to notify the user that the process won't be able to respond to RPC calls. When it is reloaded, it has another chance to add the RPC subscriber and continue functioning normally.
muhrin
approved these changes
Oct 30, 2018
This was referenced Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add_rpc_subscribercall on the communicator in theinitcallof a
Processcan timeout with aTimeoutError, but this should nottopple the process itself. Instead, it should log the error to notify
the user that the process won't be able to respond to RPC calls. When
it is reloaded, it has another chance to add the RPC subscriber and
continue functioning normally.