Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for Linux users #17

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Add instructions for Linux users #17

merged 1 commit into from
Sep 22, 2016

Conversation

hason
Copy link
Contributor

@hason hason commented Sep 21, 2016

Fixes #4


> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package.

1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are basically copy/paste from mentioned repo. It would be better not to copy/paste because instructions on external repo might change over time and then this repo will only display outdated instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you pushed your changes? I still see 1 commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, force push.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Then just move repository word to the end to be 1. clone ... repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

===================

> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package.

Copy link
Owner

@aik099 aik099 Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another paragraph saying:

If you're using other Linux distribution then follow these instructions:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package.

1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Then just move repository word to the end to be 1. clone ... repository.


1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler)
2. go to cloned folder
3. read installation instructions in README.md
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace README.md with link to README.md of that other repo.


Without the link it looks like you're referring back to same README.md that you're reading right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aik099
Copy link
Owner

aik099 commented Sep 22, 2016

Merging, thanks @hason .

@aik099 aik099 merged commit 833cc2b into aik099:master Sep 22, 2016
@hason hason deleted the linux branch September 30, 2016 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants