-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for Linux users #17
Conversation
|
||
> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package. | ||
|
||
1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are basically copy/paste from mentioned repo. It would be better not to copy/paste because instructions on external repo might change over time and then this repo will only display outdated instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you pushed your changes? I still see 1 commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, force push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Then just move repository
word to the end to be 1. clone ... repository
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
=================== | ||
|
||
> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another paragraph saying:
If you're using other Linux distribution then follow these instructions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
|
||
> If you use Arch Linux (Arch, Manjaro, Antergos, etc.), you can install [phpstorm-url-handler](https://aur.archlinux.org/packages/phpstorm-url-handler/) package. | ||
|
||
1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Then just move repository
word to the end to be 1. clone ... repository
.
|
||
1. clone repository [https://github.com/sanduhrs/phpstorm-url-handler](https://github.com/sanduhrs/phpstorm-url-handler) | ||
2. go to cloned folder | ||
3. read installation instructions in README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace README.md
with link to README.md
of that other repo.
Without the link it looks like you're referring back to same README.md that you're reading right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Merging, thanks @hason . |
Fixes #4