Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving slider to 0 range will change to the 'All' view #150

Open
amp7368 opened this issue Nov 25, 2022 · 2 comments
Open

Moving slider to 0 range will change to the 'All' view #150

amp7368 opened this issue Nov 25, 2022 · 2 comments

Comments

@amp7368
Copy link

amp7368 commented Nov 25, 2022

When loading/refreshing the timings report page, the 'count' is lower than it should be, and therefore gives a high % of tick.

When moving the slider of the timings time-range all the way to the right, and then move the slider back to where it was originally, it shows different timings that seem more accurate.

I tested this with a completely blank 1.19.2 server without any plugins and the latest version of paper at the time of writing (286). I'm using google chrome as a browser.

The timings report of the blank server
https://timings.aikar.co/dev/?id=b69fa8da578641eea89026c7195be442

Initial page load
image

Move the slider to the right
image

Restore the slider's original position
image

@electronicboy
Copy link

Default view mode is lag, which shows ticks which took too long, rather than all ticks; given jvm warmup, etc, losing a few dozen ticks on startup ks expected; you see that in your view where the count is showing all ticks, you're now in all view

@amp7368
Copy link
Author

amp7368 commented Nov 26, 2022

Oh, I see what happened! Thank you for pointing that out! I didn't notice that it changed the view mode when moving the slider.

To summarize and be make sure we're on the same page:
The default view mode is 'Lag'
Then whenever the slider has a range of 0 included ticks,
the site decides that 'All' mode should be the new view. (without me changing the view mode directly)

I misidentified what the cause of the count change was.
I'm not sure if that is the intended behavior though.
If it is, then we can close this issue now.

I don't think that moving the range slider should impact the view mode at all. I think it's quite confusing.

@amp7368 amp7368 changed the title Invalid count on first viewing of timings report Moving slider to 0 range will change to the 'All' view Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants