Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CurrentBestLearning and MinimalConsistentDet #414

Merged
merged 5 commits into from
Jun 18, 2018
Merged

Add CurrentBestLearning and MinimalConsistentDet #414

merged 5 commits into from
Jun 18, 2018

Conversation

samagra14
Copy link
Collaborator

@samagra14 samagra14 commented Jun 2, 2018 •
edited

This pull request :

  • Adds currentBestLearning.
  • Tests the algorithm on the restaurant dataset.
  • Improves the permute model.
  • Adds minimalConsistentDet.

@samagra14 samagra14 changed the title [WIP] Add CurrentBestLearning Add CurrentBestLearning Jun 3, 2018
@samagra14
Copy link
Collaborator Author

@norvig Please have a look. I have used really simple generalisation and specialisation functions for this algorithm. They can be readily changed by tuning the parameters of the algorithm.

@samagra14 samagra14 mentioned this pull request Jun 6, 2018
Closed
@samagra14 samagra14 mentioned this pull request Jun 6, 2018
Closed
@samagra14 samagra14 changed the title Add CurrentBestLearning Add CurrentBestLearning and MinimalConsistentDet Jun 6, 2018
@norvig
Copy link
Contributor

norvig commented Jun 17, 2018

I like the idea of keeping it simple. There are conflicts to be resolved.

@samagra14
Copy link
Collaborator Author

@norvig I have resolved the conflicts. Please have a look.

@norvig norvig merged commit ea718d3 into aimacode:AIMA3e Jun 18, 2018
@samagra14 samagra14 deleted the current_best_learning branch June 18, 2018 17:17
@samagra14 samagra14 mentioned this pull request Jun 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AIMA3e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samagra14 @norvig