-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for table_driven_agent_program and Random_agent_program #770
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
df5cdc8
Add test for table driven agent
nouman-10 d79819b
Some style fixes
nouman-10 a05bbfa
Added done to tabledrivenagent test in readme
nouman-10 89eb1c8
Added randomAgentProgram test to test_agents.py
nouman-10 574b520
Added Import randomAgentProgram
nouman-10 8326995
Resolved some merge conflicts in Readme.md
nouman-10 935e128
Style fixes
nouman-10 8ac2308
Added the done tag tp tabledrivenagent test
nouman-10 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after the commas in the tuples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case is same in both the cases t.e, in randomAgentProgram and randomVacuumAgent. Both do choose randomly from the given actions. But as the run method executes the step method a 1000 times, so there is almost 100 percent chance that the assertion will be true always. However, another way of doing this can be declaring actions as an attribute of the function statement and then just executing the step statement once and checking if the action does belong to the given list of actions then the program runs fine. @MrDupin Comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sounds good.
There are some conflicts with the
README
now, can you fix them? Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed them @MrDupin