Improve the rule for time series pipeline verification #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasyanovse
added
core
kasyanovse
force-pushed
the
improve_verfier_for_ts
branch
from
2db31d6
to
1e2a6e8
Compare
|
Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-15 13:57:37 UTC |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 79.15% 79.45% +0.29%
==========================================
Files 145 145
Lines 9937 9928 -9
==========================================
+ Hits 7866 7888 +22
+ Misses 2071 2040 -31 ☔ View full report in Codecov by Sentry. |
MorrisNein
requested review from
MorrisNein
and removed request for
MorrisNein
kasyanovse
force-pushed
the
improve_verfier_for_ts
branch
from
c81a444
to
52e1353
Compare
kasyanovse
force-pushed
the
improve_verfier_for_ts
branch
from
52e1353
to
77d87fe
Compare
Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>
Lopa10ko
approved these changes
Dec 4, 2023
valer1435
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new check for time series specific primary node in pipeline.