Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for unit and intergration tests #1238

Merged
merged 8 commits into from
Dec 29, 2023
Merged

Fixes for unit and intergration tests #1238

merged 8 commits into from
Dec 29, 2023

Conversation

nicl-nno
Copy link
Collaborator

  • API tests refactored

@pep8speaks
Copy link

pep8speaks commented Dec 27, 2023 •
edited

Hello @nicl-nno! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-29 13:15:18 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdfdde8) 79.47% compared to head (e5430d0) 79.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
+ Coverage   79.47%   79.90%   +0.43%     
==========================================
  Files         145      145              
  Lines        9928     9929       +1     
==========================================
+ Hits         7890     7934      +44     
+ Misses       2038     1995      -43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

valer1435
valer1435 reviewed Dec 29, 2023
View reviewed changes
examples/simple/time_series_forecasting/api_forecasting.py Outdated

# run AutoML model design in the same way
pipeline = model.fit(train_data)
pipeline = model.fit(train_data, predefined_model='auto')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А зачем здесь понадобился predefined_model?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из примера действительно можно убрать. Done.

valer1435
valer1435 reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@valer1435 valer1435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вроде ок, но с примером api идею не понял

@nicl-nno nicl-nno merged commit a35f602 into master Dec 29, 2023
6 checks passed
@nicl-nno nicl-nno deleted the test-improved branch December 29, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valer1435 valer1435 Awaiting requested review from valer1435

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicl-nno @pep8speaks @valer1435