Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paper updates #42

Merged
merged 185 commits into from Sep 27, 2022
Merged

paper updates #42

merged 185 commits into from Sep 27, 2022

Conversation

quickjkee
Copy link
Collaborator

No description provided.

nicl-nno and others added 30 commits January 19, 2022 01:05
@nicl-nno
Cells trap case added
f5b69c4
@nicl-nno
Update
f76b9f1
@quickjkee
bw design
7610ca3
@quickjkee
Merge remote-tracking branch 'origin/main'
144be5b 
# Conflicts:
#	gefest/core/algs/geom/validation.py
#	gefest/core/geometry/geometry_2d.py
@quickjkee
test fix
548484d
@quickjkee
Delete .gitignore
9301fbe
@quickjkee
Delete GEFEST.iml
2297a84
@quickjkee
Delete profiles_settings.xml
3d63753
@quickjkee
Delete modules.xml
6ed071a
@quickjkee
Delete vcs.xml
c981312
@quickjkee
Delete workspace.xml
238056e
@quickjkee
Delete CONFIG_opt.erf
2b71fa2
@quickjkee
Delete INPUT
3be654d
@quickjkee
Delete PRINT
b4906c2
@quickjkee
Delete port_not_bathy_25m_vobst_exp.bot
0fb34a8
@quickjkee
Delete model_results.db
17ca9e7
@quickjkee
Delete norm_end
51ee626
@quickjkee
Delete hs47dd8b1c0d4447478fec6f956c7e32d9.d
3f021e1
@quickjkee
Delete swaninit
aa918b4
@quickjkee
Delete swanrun.bat
f7949ad
@quickjkee
Delete wind.lst
49ab9ca
@quickjkee
Delete history_def.csv
87e9c7a
@quickjkee
some fixes
9db403d
@quickjkee
swan files
9044a23
@quickjkee
swan files
6992223
@quickjkee
pep fixes
d3416a0
@quickjkee
Delete CONFIG_opt.erf
cba323b
@quickjkee
Delete PRINT
510d0ce
@quickjkee
Delete hs47dd8b1c0d4447478fec6f956c7e32d9.d
984169b
@quickjkee
Delete norm_end
02961b3
@pep8speaks
Copy link

Hello @quickjkee! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 28:21: W292 no newline at end of file

Line 19:19: W292 no newline at end of file

Line 28:21: W292 no newline at end of file

Line 19:19: W292 no newline at end of file

Line 24:1: W391 blank line at end of file

Line 8:1: E402 module level import not at top of file
Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file

Line 147:68: E502 the backslash is redundant between brackets
Line 161:13: E266 too many leading '#' for block comment
Line 213:48: E502 the backslash is redundant between brackets
Line 218:13: E266 too many leading '#' for block comment
Line 239:88: E502 the backslash is redundant between brackets

Line 197:20: W292 no newline at end of file

Line 8:1: E402 module level import not at top of file
Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 12:1: E402 module level import not at top of file

Line 53:2: W292 no newline at end of file

nicl-nno
nicl-nno requested changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@nicl-nno nicl-nno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Общие комментарии помимо тех что в коде:

1)В наборе коммитов всё ещё есть лишние (например, мои январские). Возможно часть лишних файлов - из-за них. Предлагаю для удобства схлопнуть все твои правки в 1 коммит.
Алсо, у тебя есть права на этот репозиторий, т.ч. не обязательно из форка работать.

  1. Всякие tmp_images - они нужны? Если они служат в качестве примеров - стоит это отразить в названии. Если не нужны - то удалить.

  2. Там по мелочи есть предупрежддения по PEP8 - поправь плз.

  3. Кое-где у функций и классов потерялись докстринги, type hint-ы и т.п. Если они актуальны - то перенеси их в свою ветку, если нет - то скорректируй или оставь TODO.

README.md Outdated Show resolved Hide resolved
cases/breakwaters/configuration_de/bw_optimizer.py Show resolved Hide resolved
cases/breakwaters/configuration_de/bw_sampler.py Show resolved Hide resolved
cases/breakwaters/configuration_spea2/bw_estimator.py Outdated Show resolved Hide resolved
cases/breakwaters/main.py Outdated Show resolved Hide resolved
gefest/tools/estimators/simulators/swan/swan_model/INPUT2 Outdated Show resolved Hide resolved
gefest/tools/estimators/simulators/swan/swan_model/PRINT Outdated Show resolved Hide resolved
gefest/tools/estimators/simulators/swan/swan_model/norm_end Outdated Show resolved Hide resolved
gefest/tools/samplers/sampler.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
nicl-nno
nicl-nno reviewed Sep 5, 2022
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@nicl-nno
Copy link
Contributor

@pep8speaks pls update youself

@nicl-nno
Copy link
Contributor

nicl-nno commented Sep 23, 2022 •
edited

TODO так TODO, но перед аппрувом поправь плз пункты 1, 2 и 4 (кое-где возвращаемые типы потерялись) из комментария выше.

P.S. экшен с гитлабом видимо падает из-за того что у тебя форк. Ну черт с ним.

@quickjkee quickjkee changed the base branch from main to paper-upds September 27, 2022 14:05
@quickjkee quickjkee merged commit 93d26b5 into aimclub:paper-upds Sep 27, 2022
quickjkee added a commit that referenced this pull request Sep 27, 2022
@quickjkee
paper updates (#42) (#46)
ad1b4c1 
* Modifications corresponding to the paper
@nicl-nno nicl-nno mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicl-nno nicl-nno nicl-nno requested changes

@DenisSidoren DenisSidoren Awaiting requested review from DenisSidoren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quickjkee @pep8speaks @nicl-nno