Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basket save operation for multiple baskets #10

Merged
merged 1 commit into from Feb 15, 2021
Merged

Fix basket save operation for multiple baskets #10

merged 1 commit into from Feb 15, 2021

Conversation

faheem00
Copy link
Contributor

When a basket has a predefined ID (for multiple baskets), a Basket Empty error is thrown during basket save operation. This occurs because the basket ID is not set in the controller before check operation is done.

This PR fixes the issue by attaching the cart ID to the controller earlier, thereby making sure that subsequent calls to the controller will return the correct basket.

This issue was first posted on https://aimeos.org/help/post13915.html

When a basket has a predefined ID (for multiple baskets), a `Basket Empty` error is thrown during basket save operation. This occurs because the basket ID is not set in the controller before check operation is done.

This PR fixes the issue by attaching the cart ID to the controller earlier, thereby making sure that subsequent calls to the controller will return the correct basket.

This issue was first posted on https://aimeos.org/help/post13915.html
@aimeos
Copy link
Owner

aimeos commented Feb 15, 2021

Great! Thanks a lot for your fix!

@aimeos aimeos merged commit 718f4ec into aimeos:2020.10 Feb 15, 2021
aimeos pushed a commit that referenced this pull request Feb 15, 2021
When a basket has a predefined ID (for multiple baskets), a `Basket Empty` error is thrown during basket save operation. This occurs because the basket ID is not set in the controller before check operation is done.
@aimeos
Copy link
Owner

aimeos commented Feb 15, 2021

You can use:

composer req aimeos/ai-client-jsonapi:2020.10.x-dev

until a new release is tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants