Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant support to PropertyAdd plugin #252

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add variant support to PropertyAdd plugin #252

wants to merge 9 commits into from

Commits on Sep 28, 2021

  1. Expressions now query on product codes not IDs

    @iammart
    iammart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    77f8aea View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @iammart
    iammart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    a74644e View commit details
    Browse the repository at this point in the history

  3. Combine properties from both products

    @iammart
    iammart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b1f67c0 View commit details
    Browse the repository at this point in the history

  4. Implement feedback 

    Im commiting blind in the browser again, if there is anything I miss im really going to need to spend some time to understand and setup phing.
    @iammart
    iammart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    688a6bb View commit details
    Browse the repository at this point in the history

  5. Fix failing tests

    Mart Dingley committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    29a2fd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Fix phpcs errors using ruleset

    Mart Dingley committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    3c25655 View commit details
    Browse the repository at this point in the history

  2. Change type hints on method signature to iterable

    Mart Dingley committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    5dd0830 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Refactor

    Mart Dingley committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    07ebf05 View commit details
    Browse the repository at this point in the history

  2. Move logic from getProperties into addAttributes

    Mart Dingley committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    a6f0848 View commit details
    Browse the repository at this point in the history