New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom submanager names #297
Conversation
@@ -73,8 +73,12 @@ public static function create( \Aimeos\MShop\ContextIface $context, | |||
if( empty( $name ) ) | |||
{ | |||
$subpath = !empty( $parts ) ? join( '/', $parts ) . '/' : ''; | |||
$name = $config->get( 'mshop/' . $domain . '/manager/' . $subpath . 'name' ); | |||
$name = $name ?: $config->get( 'mshop/' . $domain . '/manager/name', 'Standard' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a name is passed as argument to that method, it's not used any more in your code
What's the problem with the current implementations? Can you give an example when it will fail? |
I wrote here an example: https://aimeos.org/help/viewtopic.php?f=15&t=4690&p=18424 |
We've shortend and improved the code a bit so it passes the tests :-) |
The patch has been backported to the 2022.07 branch and a new release (2022.07.6) has been tagged. Can you please confirm that this fixes the problem? |
Ok, now it's all ok. Thank you! |
The change crashed other code parts and would have led to a heavy breaking change in the stable release. In the current dev-master branch, this has been changed again to simplify configuration but until (and including 2022.10 LTS), you should be able to configure your managers in your return [
'customer' => [
'manager' => [
'name' => 'Myproject',
'address' => [
'name' => 'Standard'
],
'list' => [
'name' => 'Myproject',
'type' => [
'name' => 'Standard'
]
],
'property' => [
'name' => 'Myproject',
'type' => [
'name' => 'Standard'
]
]
]
]
]; |
No, it doesn't work for me.
and I have this exception for example: I also tried to edit the locale array like this, but nothing change:
|
Your configuration must be:
|
No description provided.