Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements secret() for passwords instead of ask() #3

Merged
merged 2 commits into from
Dec 23, 2017
Merged

Implements secret() for passwords instead of ask() #3

merged 2 commits into from
Dec 23, 2017

Conversation

philip
Copy link
Contributor

@philip philip commented Dec 22, 2017

No description provided.

@aimeos
Copy link
Owner

aimeos commented Dec 22, 2017

Thanks for your PR!
One minor improvement: Can you move asking for the DB and MAIL password out of the loop so they are asked at last and you don't need the if/else statements?

@philip
Moved *_PASSWORD prompts out of loop and hid value
4705c7e 
They still use secret() instead of ask(), and now also hide the current value.
@philip
Copy link
Contributor Author

philip commented Dec 22, 2017

Excellent suggestion, I knew something just didn't feel right :) Done.

Also, the current *_PASSWORD value is no longer printed.

@aimeos
Copy link
Owner

aimeos commented Dec 23, 2017

Great! Thank you very much! We appreciate your contributions :-)

@aimeos aimeos merged commit 5e32f00 into aimeos:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philip @aimeos