New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Import Image
and Audio
for TensorboardFolderTracker
#2669
[fix] Import Image
and Audio
for TensorboardFolderTracker
#2669
Conversation
Image
and Audio
for TensorboardFolderTracker
Image
and Audio
for TensorboardFolderTracker
Image
and Audio
for TensorboardFolderTracker
Image
and Audio
for TensorboardFolderTracker
@alansaul thanks a lot for contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Waiting for the CHANGELOG update to approve changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alansaul looks great! 🎉
Thanks a lot!
Please sign the CLA so I can merge the PR.
@alansaul, just a reminder to sign the CLA, as it blocks the PR merge. |
@alansaul could you please sign the CLA, so we can merge the fix? |
Apologies for the delay, I've merged upstream and signed the CLA, and fixed the changelog |
It looks like this PR has tripped your coverage threshold of 50%. I don't think this PR should be further tested though, as the bulk of the PR itself is additional tests that didn't already exist, rather than code that needs to be tested. |
Yes, @alansaul, the coverage drop is a result of other changes. Seems the pipeline failed on this PR after to synching it with main. I'm going to address low coverage by a separate PR, so it should be fine to merge this one now. |
# Conflicts: # CHANGELOG.md
Image
andAudio
to be always importedtorch
's utilities.Resolves #2668