Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high timeout for lock function #3089

Closed
wants to merge 1 commit into from
Closed

Add high timeout for lock function #3089

wants to merge 1 commit into from

Conversation

inc0
Copy link
Contributor

@inc0 inc0 commented Jan 10, 2024

Lock is meant to be waited on. In server case, unfortunately, this means waiting on grpc. This times out on cliend side and throws error. I'm not happy with this solution, it feels hacky. There should be better way to add such timeouts, but this conditional will cause minimal disruption to current behavior of code.

Fixes #2999

Lock is meant to be waited on. In server case, unfortunately, this means waiting on grpc. This times out on cliend side and throws error.
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Michal Jastrzebski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@inc0
Copy link
Contributor Author

inc0 commented Jan 10, 2024

some more testing - introduced other issues

@inc0 inc0 closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with aim.Run when using hash to locate a run
2 participants