[fix] Always set the run name when initializing a run in lightning #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the run name would only be set when a run hash has been specified by the user, which is only the case in unusual circumstances, e.g. when a previous model training is resumed at a later time. In effect, run names were never set in my case.
|
|
martenlienen
changed the title
mihran113
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Hey @martenlienen! Thanks a lot for contribution, and sorry for late response :) Can I ask you to add an entry for this PR as well in changelog?
alberttorosyan
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the run name would only be set when a run hash has been specified by the user, which is only the case in unusual circumstances, e.g. when a previous model training is resumed at a later time. In effect, run names were never set in my case.
Best,
Marten