Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Change transport from grpc to http(fastapi) for tracking server #3103

Merged
merged 8 commits into from Feb 27, 2024
Merged

[feat] Change transport from grpc to http(fastapi) for tracking server #3103

merged 8 commits into from Feb 27, 2024

Conversation

mihran113
Copy link
Contributor

No description provided.

@mihran113 mihran113 self-assigned this Feb 23, 2024
@mihran113 mihran113 marked this pull request as draft February 23, 2024 12:26
@mihran113 mihran113 marked this pull request as ready for review February 23, 2024 17:16
@mihran113
Copy link
Contributor Author

Resolves #3104

alberttorosyan
alberttorosyan approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused packages from requirements in setup.py.
The rest looks good.

@mihran113 mihran113 merged commit 3373cbb into main Feb 27, 2024
4 checks passed
@mihran113 mihran113 deleted the feature/http-transport branch February 27, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberttorosyan alberttorosyan alberttorosyan approved these changes

Assignees

@mihran113 mihran113

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mihran113 @alberttorosyan