Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding when scrolling down #15

Closed
kkristof200 opened this issue Sep 30, 2016 · 2 comments
Closed

Hiding when scrolling down #15

kkristof200 opened this issue Sep 30, 2016 · 2 comments
Labels

Comments

@kkristof200
Copy link

Hey,

First of all I really like your work and thanks a lot for making it!
Since I'm not a web dev, I only understand the code so and so, but I want to implement a "hide/show" feature depending on the scrolling direction. I've googled a lot, but couldn't really solve the problem, so I thought that the best solution would be posting a question here.
Here is a link to show what do I want exactly:
http://jsfiddle.net/mariusc23/s6mLJ/31/

Thanks a lot,
Kristof Kovacs

@ain ain added the question label Oct 1, 2016
@ain
Copy link
Owner

ain commented Oct 1, 2016

Thanks for the question @kkristof200.

Interesting request and I can see the use case. I'm mixed about possible implementation though as it'd be wrong to add another responsibility to smartbanner.js esp. considering the level of complexity that libraries like skrollr or ScrollMagic have to offer.

I'm more trending towards open API approach that'd allow interaction with smartbanner.js so one could add ScrollMagic to their project and call smartbanner hide/show from ScrollMagic handlers accordingly.

As for the current workaround you could work with the smartbanner div element already and implement its hiding by working with the container div directly from ScrollMagic.

@kkristof200
Copy link
Author

Thank you a lot for your fast response! Keep it up! :D

@ain ain mentioned this issue Oct 2, 2016
Closed
@ain ain closed this as completed Oct 2, 2016
Repository owner locked and limited conversation to collaborators Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants