-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we set cookie expires time #28
Comments
Hi @aspmaker, thank you for your interest. Currently not. At the moment Nevertheless, I can't see any arguments against such feature and I can see your use-case. I'd gladly accept your Pull Request with this feature. Before you start, please see contribution guidelines and make sure you add tests against your feature. |
@ain Apple docs state that banner won't reappear, so cookie per session doesn't mock the original behavior.
|
@igor10k you're probably right. Nevertheless, it's not a good idea to change this behaviour due to legacy reasons, but I'd be more than glad to merge a reasonable PR on this. |
Landed in v1.6.0. |
Hello. Can we set cookie value (smartbanner_exited) in js code ? Example i want to show banner every 15 day and only one time. Thank you.
The text was updated successfully, but these errors were encountered: