Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.MD with instructions on installing Bundler and linting SCSS #48

Merged
merged 2 commits into from
May 10, 2017

Conversation

theonicolaou
Copy link
Contributor

No description provided.

Copy link
Owner

@ain ain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please see the last bit there before we'll merge.

CONTRIBUTING.md Outdated
To lint an SCSS file, run:

```
scss-lint src/<filename>.scss
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task for SCSS linting already exist and is easy to run:

npm run scsslint

Let's change to it. There's already a plan to shift from RubyGems to Node.js based SCSS linter anyway, see #49.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem - I've made the requested change

@ain ain merged commit a87c82b into ain:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants