V1 release #14

ainformatico · 2018-06-10T20:39:12Z

Description

This is the V1 release:

Drop support for old Ruby versions
Update gems
Rubocop love
Add Coveralls support
Improve general coding
Add support for custom params (e.g private_domain)

TODO

Merge Updated Mailinator to support Private Domain #13

Add new ones

ruby/www.ruby-lang.org#1777

houndci-bot · 2018-06-11T20:31:25Z

spec/lib/mailinator/email_spec.rb

-    expect(message.forwards_left).to eq(10)
-    expect(message.original).to be_a(Hash)
-  end
+  describe '#get' do


Metrics/BlockLength: Block has too many lines. [31/25]

ainformatico · 2018-06-24T14:02:15Z

@mattrobbins changes on this PR are finished, just waiting for your changes and we can make the release of V1.

Support private domain and custom options

houndci-bot · 2018-07-03T06:15:06Z

spec/support/fake_web.rb

@@ -32,3 +33,5 @@ def register_uri(url, file, method = :get)
 register_uri('http://api.mailinator.com:443/api/error?token=ABCD', 'error.response')
 register_uri('http://api.mailinator.com:443/api/delete?msgid=abcd1234&token=ABCD', 'delete.response')
 register_uri('http://api.mailinator.com:443/api/delete?msgid=1419696967-44152505-recipient&token=ABCD', 'delete.response')
+register_uri('http://api.mailinator.com:443/api/inbox?private_domain=true&to=abcd1234&token=ABCD', 'inbox_private.response')
+register_uri('http://api.mailinator.com:443/api/email?private_domain=true&msgid=1419696967-44152505-recipient&token=ABCD', 'email_private.response')


Metrics/LineLength: Line is too long. [148/80]

houndci-bot · 2018-07-03T06:15:06Z

spec/support/fake_web.rb

@@ -32,3 +33,5 @@ def register_uri(url, file, method = :get)
 register_uri('http://api.mailinator.com:443/api/error?token=ABCD', 'error.response')
 register_uri('http://api.mailinator.com:443/api/delete?msgid=abcd1234&token=ABCD', 'delete.response')
 register_uri('http://api.mailinator.com:443/api/delete?msgid=1419696967-44152505-recipient&token=ABCD', 'delete.response')
+register_uri('http://api.mailinator.com:443/api/inbox?private_domain=true&to=abcd1234&token=ABCD', 'inbox_private.response')


Metrics/LineLength: Line is too long. [124/80]

houndci-bot · 2018-07-03T06:15:06Z

spec/support/fake_web.rb

@@ -21,6 +20,8 @@ def register_uri(url, file, method = :get)
 register_uri('https://api.mailinator.com/api/error?token=ABCD', 'error.response')
 register_uri('https://api.mailinator.com/api/delete?msgid=abcd1234&token=ABCD', 'delete.response')
 register_uri('https://api.mailinator.com/api/delete?msgid=1419696967-44152505-recipient&token=ABCD', 'delete.response')
+register_uri('https://api.mailinator.com/api/inbox?private_domain=true&to=abcd1234&token=ABCD', 'inbox_private.response')
+register_uri('https://api.mailinator.com/api/email?private_domain=true&msgid=1419696967-44152505-recipient&token=ABCD', 'email_private.response')


Metrics/LineLength: Line is too long. [145/80]

houndci-bot · 2018-07-03T06:15:06Z

spec/support/fake_web.rb

@@ -21,6 +20,8 @@ def register_uri(url, file, method = :get)
 register_uri('https://api.mailinator.com/api/error?token=ABCD', 'error.response')
 register_uri('https://api.mailinator.com/api/delete?msgid=abcd1234&token=ABCD', 'delete.response')
 register_uri('https://api.mailinator.com/api/delete?msgid=1419696967-44152505-recipient&token=ABCD', 'delete.response')
+register_uri('https://api.mailinator.com/api/inbox?private_domain=true&to=abcd1234&token=ABCD', 'inbox_private.response')


Metrics/LineLength: Line is too long. [121/80]

houndci-bot · 2018-07-03T06:15:07Z

spec/lib/mailinator/inbox_private_spec.rb

+require 'spec_helper'
+
+describe Mailinator::Inbox do
+  let(:inbox_private) {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2018-07-03T06:15:07Z

spec/lib/mailinator/inbox_private_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-07-03T06:15:07Z

spec/lib/mailinator/email_spec.rb

+        expect(message.subject).to eq('This is a Subject')
+        expect(message.request_id).to eq('638363')
+        expect(message.body).to include('<p>This is a body</p>')
+        expect(message.body_base_64).to include('This is a BASE64 body JVBERi0xLjUKJe')


Metrics/LineLength: Line is too long. [87/80]

houndci-bot · 2018-07-03T06:15:07Z

spec/lib/mailinator/email_spec.rb

+        expect(message.from_full).to eq('example@example.net')
+        expect(message.date).to be_a(DateTime)
+        expect(message.received)
+        .to include('from bmta1.example.com([9.9.9.9]) by mail.mailinator.com with SMTP (Postfix) for receipient@example.com; Fri, 11 May 2018 20:55:36 +0000 (UTC)')


Layout/MultilineMethodCallIndentation: Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Metrics/LineLength: Line is too long. [165/80]

houndci-bot · 2018-07-03T06:15:07Z

spec/lib/mailinator/email_spec.rb

-    expect(message.forwards_left).to eq(10)
-    expect(message.original).to be_a(Hash)
-  end
+  describe '#get' do


Metrics/BlockLength: Block has too many lines. [29/25]

houndci-bot · 2018-07-03T06:15:07Z

lib/mailinator/models/email.rb

 require 'date'

 module Mailinator
  module Models
    class Email < Base
      def transform_data
        {
-          id: @data['data']['id'],
+          from_full: @data['data']['fromfull'],
+          date: DateTime.parse(@data['data']['headers']['date']),


Style/DateTime: Prefer Date or Time over DateTime.

ainformatico · 2018-07-03T06:17:14Z

@mattrobbins I will now make the last changes to this PR, merge it and release V1. Thanks a lot for your contribution 😄

ainformatico added 7 commits June 10, 2018 22:31

Drop support for old Ruby versions in Travis

59df765

Add new ones

Update gems

0f79b6d

Rubocop love

e39aa9a

Remove ruby 2.2.0

390cbc8

ruby/www.ruby-lang.org#1777

Add Coveralls support

db1280b

Coverall badge

6cd0b32

Add Gemfile.lock

9c6d4a8

ainformatico mentioned this pull request Jun 10, 2018

Updated Mailinator to support Private Domain #13

Merged

ainformatico added 6 commits June 11, 2018 20:34

Improve coding for api

fa2574c

Remove unused code

df7c673

Improve coding for config

9d95137

Improve coding for email

4fc821a

Improve coding for inbox

9f9ca9c

Improve coding for model

b2612f8

houndci-bot reviewed Jun 11, 2018

View reviewed changes

ainformatico added 6 commits June 11, 2018 22:34

Improve coding for mailinator

9a04537

Update version

753b722

Update more gems

2b848de

Fix travis build

e29b5c8

Try a fix for broken build

16ca5fe

Fix Coveralls

d4b1702

Add Gemfile.lock

9877be3

ainformatico force-pushed the v1-release branch from 2e3a5d8 to 9877be3 Compare June 26, 2018 06:39

Updated Mailinator to support Private Domain (#13)

e661b4d

Support private domain and custom options

houndci-bot reviewed Jul 3, 2018

View reviewed changes

ainformatico added 2 commits July 3, 2018 08:38

Rubocop love

070bb24

No more should

76bb480

ainformatico merged commit d5a0969 into master Jul 3, 2018

ainformatico deleted the v1-release branch July 3, 2018 06:47

ainformatico mentioned this pull request Jul 6, 2018

Publish new gem version #11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V1 release #14

V1 release #14

ainformatico commented Jun 10, 2018 •

edited

houndci-bot Jun 11, 2018

ainformatico commented Jun 24, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

houndci-bot Jul 3, 2018

ainformatico commented Jul 3, 2018

V1 release #14

V1 release #14

Conversation

ainformatico commented Jun 10, 2018 • edited

Description

TODO

Choose a reason for hiding this comment

ainformatico commented Jun 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ainformatico commented Jul 3, 2018

ainformatico commented Jun 10, 2018 •

edited