Feature/donghoon/refactor codes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
589hero
commented
Sep 5, 2022
589hero
commented
- Chess Bot 코드 리팩토링 작업을 거쳤습니다.
byeongal
reviewed
Sep 7, 2022
|
|
||
|
|
||
| def get_legal_moves(user_id: str) -> List[str]: | ||
| legal_moves = list(user_chess[user_id].legal_moves) |
There was a problem hiding this comment.
minor) user_chess 선언 부분을 82번째 줄 보다 위에 있는게 좋을 것 같습니다.
byeongal
reviewed
Sep 7, 2022
src/bot.py
Outdated
| # 사용자가 게임을 시작 안했거나 게임이 끝나, 체스판 정보에 없을 때에 /move 시도 시 에러 표기 (Discord) | ||
| if interaction.user.id not in user_chess.keys(): | ||
| if user_id not in user_chess.keys(): |
There was a problem hiding this comment.
user_id not in user_chess.keys(): -> user_id not in user_chess:
Laeyoung
reviewed
Sep 7, 2022
| @@ -38,17 +41,18 @@ async def on_ready(self): | |||
| print(f"We have logged in as {self.user}.") | |||
|
|
|||
|
|
|||
| client = aclient() | |||
byeongal
reviewed
Sep 7, 2022
| return embed, display_board(user_chess[interaction.user.id]) | ||
| view = View() | ||
| await interaction.response.send_message( | ||
| embed=embed, file=display_board(user_chess[user_id]), view=view, ephemeral=True |
There was a problem hiding this comment.
minor) ephemeral=True가 다른 사람이 메세지를 못 보는데 이럴 경우 해당 봇이 죽었는지 살았는지 모를 것 같습니다.
byeongal
reviewed
Sep 7, 2022
| del user_prompt[interaction.user.id] | ||
| await interaction.followup.send("<@" + str(interaction.user.id) + "> won the game.", ephemeral=True) | ||
| delete_user_chess_info(user_id) | ||
| await interaction.followup.send(f"<@{user_id}> won the game.", ephemeral=True) |
byeongal
reviewed
Sep 7, 2022
| await interaction.followup.send("<@" + str(interaction.user.id) + "> lost the game.", ephemeral=True) | ||
| if not legal_moves: | ||
| delete_user_chess_info(user_id) | ||
| await interaction.followup.send(f"<@{user_id}> lost the game.", ephemeral=True) |
byeongal
reviewed
Sep 7, 2022
| ) | ||
| async def button_callback(interaction: discord.Interaction): | ||
| delete_user_chess_info(user_id) | ||
| await interaction.response.send_message(f"<@{user_id}> resigned the game.", ephemeral=True) |
byeongal
reviewed
Sep 7, 2022
| user_color = {} # {'user_id': 'White', ...} | ||
| user_count = defaultdict(int) # {'user_id': 1, ...} | ||
| user_prompt = defaultdict(list) # {'user_id': ['1.', 'e4', 'e5'], ...} | ||
| await interaction.followup.send(embed=embed, file=display_board(user_chess[user_id]), view=view, ephemeral=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.