fix socket.error raises (#1129)

aio-libs-abandoned · Nov 29, 2021 · dbdd0ad · dbdd0ad
1 parent 2ba15fb
commit dbdd0ad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGES/1129.bugfix b/CHANGES/1129.bugfix
@@ -0,0 +1 @@
+fixed raw socket.error (or one of its subclasses) raises instead of a redis.exceptions.ConnectionError
diff --git a/aioredis/connection.py b/aioredis/connection.py
@@ -901,6 +901,11 @@ async def read_response(self):
         except asyncio.TimeoutError:
             await self.disconnect()
             raise TimeoutError(f"Timeout reading from {self.host}:{self.port}")
+        except OSError as e:
+            await self.disconnect()
+            raise ConnectionError(
+                f"Error while reading from {self.host}:{self.port} : {e.args}"
+            )
         except BaseException:
             await self.disconnect()
             raise

diff --git a/aioredis/exceptions.py b/aioredis/exceptions.py
@@ -7,7 +7,7 @@ class RedisError(Exception):
     pass
 
 
-class ConnectionError(builtins.ConnectionError, RedisError):
+class ConnectionError(RedisError):
     pass