Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix for multi-exec transaction cancelled error #225

Merged
merged 2 commits into from
May 12, 2017

Conversation

popravich
Copy link
Contributor

This fixes the issue when using redis pool and executing 'slow' mutli-exec command:
pool-owned connection was getting released back to pool before result of exec was received.

@codecov-io
Copy link

codecov-io commented May 12, 2017

Codecov Report

Merging #225 into master will increase coverage by 0.05%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   96.67%   96.72%   +0.05%     
==========================================
  Files          55       55              
  Lines        7424     7425       +1     
  Branches      624      622       -2     
==========================================
+ Hits         7177     7182       +5     
+ Misses        187      183       -4     
  Partials       60       60
Impacted Files Coverage Δ
tests/transaction_commands_test.py 100% <100%> (ø) ⬆️
aioredis/commands/transaction.py 86.95% <88.88%> (+2.23%) ⬆️
aioredis/sentinel/pool.py 90.23% <0%> (-0.53%) ⬇️
aioredis/commands/pubsub.py 96.2% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4d78b...fa70e60. Read the comment docs.

@popravich popravich added the bug label May 12, 2017
@popravich popravich merged commit 955bb31 into master May 12, 2017
@popravich popravich deleted the multi_exec_cancelled branch May 12, 2017 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants