This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Added 'exist' param to the 'zadd' method as ability setup NX or XX argument #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastak
force-pushed
the
feature/zadd-nx-xx
branch
from
84883c9
to
8c53d38
Compare
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 96.86% 96.83% -0.03%
==========================================
Files 59 59
Lines 7553 7582 +29
Branches 599 602 +3
==========================================
+ Hits 7316 7342 +26
- Misses 173 175 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
|
@mastak if you have time try to update from master |
mastak
force-pushed
the
feature/zadd-nx-xx
branch
from
90af687
to
f88cf87
Compare
mastak
force-pushed
the
feature/zadd-nx-xx
branch
from
f88cf87
to
71ef8e4
Compare
|
@pcinkh |
popravich
suggested changes
Oct 17, 2017
aioredis/commands/sorted_set.py
Outdated
| @@ -18,7 +18,10 @@ class SortedSetCommandsMixin: | |||
| ZSET_AGGREGATE_MIN = 'ZSET_AGGREGATE_MIN' | |||
| ZSET_AGGREGATE_MAX = 'ZSET_AGGREGATE_MAX' | |||
|
|
|||
| def zadd(self, key, score, member, *pairs): | |||
| SET_IF_NOT_EXIST = 'SET_IF_NOT_EXIST' # NX | |||
| SET_IF_EXIST = 'SET_IF_EXIST' # XX | |||
There was a problem hiding this comment.
Ouch, these two constants will conflict with the same ones in aioredis/commands/string.py.
Please rename both to ZSET_IF_NOT_EXIST / ZSET_IF_EXIST
|
Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
existparameter to thezaddmethod as ability setup NX or XX argument.