This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Support maxclients error #186 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new connection tries to get connected to the redis server and it has been configured with a maximum number of connections, the client will get a `MaxClientsError` exception if this limit is reached out. Also if a pool initialization with a `min_size` that can meet the requirements - beucase of that limit u others issues - the pool creation will return also a `MaxClientsError`.
popravich
force-pushed
the
support_maxclients_error
branch
from
d19334b
to
29c360b
Compare
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 96.7% 96.78% +0.08%
==========================================
Files 54 55 +1
Lines 7710 7747 +37
Branches 611 615 +4
==========================================
+ Hits 7456 7498 +42
+ Misses 185 181 -4
+ Partials 69 68 -1
Continue to review full report at Codecov.
|
|
Thanks for taking care of that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #262;
Resolves #186 and #262 ;