Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Update sorted set commands to return list[tuple] instead of plain list. #334

Merged
merged 2 commits into from
Nov 17, 2017

Conversation

popravich
Copy link
Contributor

Amend sorted set commands to return pairs instead of plain list when withscores argument is set to True (resolves #209)

…'withscores' argument is set to True (resolves #209)
@popravich popravich added this to the v1.0 milestone Nov 17, 2017
@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #334 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   96.71%   96.75%   +0.04%     
==========================================
  Files          55       55              
  Lines        7818     7807      -11     
  Branches      625      625              
==========================================
- Hits         7561     7554       -7     
+ Misses        184      183       -1     
+ Partials       73       70       -3
Impacted Files Coverage Δ
aioredis/commands/sorted_set.py 100% <100%> (ø) ⬆️
tests/sorted_set_commands_test.py 100% <100%> (ø) ⬆️
aioredis/commands/pubsub.py 95.65% <0%> (+1.08%) ⬆️
tests/sentinel_failover_test.py 87.21% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49da195...77f53bc. Read the comment docs.

@popravich popravich merged commit c784916 into master Nov 17, 2017
@popravich popravich deleted the sorted_set_pairs branch November 17, 2017 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set commands WITHSCORES should return tuples
1 participant