Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

reduce encode_command cost about 60%+ #397

Merged
merged 2 commits into from
Mar 27, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions aioredis/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,27 @@
_converters = {
bytes: lambda val: val,
bytearray: lambda val: val,
str: lambda val: val.encode('utf-8'),
int: lambda val: str(val).encode('utf-8'),
float: lambda val: str(val).encode('utf-8'),
str: lambda val: val.encode(),
int: lambda val: b'%d' % val,
float: lambda val: b'%r' % val,
}


def _bytes_len(sized):
return str(len(sized)).encode('utf-8')


def encode_command(*args):
"""Encodes arguments into redis bulk-strings array.

Raises TypeError if any of args not of bytearray, bytes, float, int, or str
type.
"""
buf = bytearray()
buf = bytearray(b'*%d\r\n' % len(args))

def add(data):
return buf.extend(data + b'\r\n')

add(b'*' + _bytes_len(args))
for arg in args:
if type(arg) in _converters:
try:
for arg in args:
barg = _converters[type(arg)](arg)
add(b'$' + _bytes_len(barg))
add(barg)
else:
raise TypeError("Argument {!r} expected to be of bytearray, bytes,"
" float, int, or str type".format(arg))
buf.extend(b'$%d\r\n%s\r\n' % (len(barg), barg))
except KeyError as exc:
raise TypeError("Argument {!r} expected to be of bytearray, bytes,"
" float, int, or str type".format(arg))
return buf


Expand Down